diff --git a/src/applications/maniphest/controller/ManiphestTaskDetailController.php b/src/applications/maniphest/controller/ManiphestTaskDetailController.php --- a/src/applications/maniphest/controller/ManiphestTaskDetailController.php +++ b/src/applications/maniphest/controller/ManiphestTaskDetailController.php @@ -143,6 +143,9 @@ ->setViewer($viewer) ->buildEditEngineCommentView($task); + $timeline->setQuoteRef($monogram); + $comment_view->setTransactionTimeline($timeline); + return $this->newPage() ->setTitle($title) ->setCrumbs($crumbs) diff --git a/src/applications/maniphest/editor/ManiphestEditEngine.php b/src/applications/maniphest/editor/ManiphestEditEngine.php --- a/src/applications/maniphest/editor/ManiphestEditEngine.php +++ b/src/applications/maniphest/editor/ManiphestEditEngine.php @@ -73,7 +73,6 @@ // - Don't show "change status" for closed tasks. // - Don't show "change owner" for closed tasks. // - Don't let users change a task status to "Duplicate". - // - Make sure "Quote" works. // - When closing an unassigned task, assign the closing user. // - Make sure implicit CCs on actions are working reasonably. diff --git a/src/applications/paste/controller/PhabricatorPasteViewController.php b/src/applications/paste/controller/PhabricatorPasteViewController.php --- a/src/applications/paste/controller/PhabricatorPasteViewController.php +++ b/src/applications/paste/controller/PhabricatorPasteViewController.php @@ -64,8 +64,9 @@ ), $source_code); + $monogram = $paste->getMonogram(); $crumbs = $this->buildApplicationCrumbs() - ->addTextCrumb('P'.$paste->getID(), '/P'.$paste->getID()); + ->addTextCrumb($monogram, '/'.$monogram); $timeline = $this->buildTransactionTimeline( $paste, @@ -75,6 +76,9 @@ ->setViewer($viewer) ->buildEditEngineCommentView($paste); + $timeline->setQuoteRef($monogram); + $comment_view->setTransactionTimeline($timeline); + return $this->newPage() ->setTitle($paste->getFullName()) ->setCrumbs($crumbs) diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php --- a/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php +++ b/src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php @@ -23,6 +23,7 @@ private $currentVersion; private $versionedDraft; private $editTypes; + private $transactionTimeline; public function setObjectPHID($object_phid) { $this->objectPHID = $object_phid; @@ -110,8 +111,16 @@ return $this->editTypes; } - public function render() { + public function setTransactionTimeline( + PhabricatorApplicationTransactionView $timeline) { + + $timeline->setQuoteTargetID($this->getCommentID()); + + $this->transactionTimeline = $timeline; + return $this; + } + public function render() { $user = $this->getUser(); if (!$user->isLoggedIn()) { $uri = id(new PhutilURI('/login/'))