diff --git a/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php b/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php index 5fade77d07..506817b0fc 100644 --- a/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php +++ b/src/applications/maniphest/xaction/ManiphestTaskTitleTransaction.php @@ -1,74 +1,75 @@ getTitle(); } public function applyInternalEffects($object, $value) { $object->setTitle($value); } public function getActionStrength() { return 1.4; } public function getActionName() { $old = $this->getOldValue(); - $new = $this->getNewValue(); - if ($old === null) { + + if (!strlen($old)) { return pht('Created'); } return pht('Retitled'); } public function getTitle() { $old = $this->getOldValue(); - if ($old === null) { + + if (!strlen($old)) { return pht( '%s created this task.', $this->renderAuthor()); } return pht( '%s renamed this task from %s to %s.', $this->renderAuthor(), $this->renderOldValue(), $this->renderNewValue()); } public function getTitleForFeed() { $old = $this->getOldValue(); if ($old === null) { return pht( '%s created %s.', $this->renderAuthor(), $this->renderObject()); } return pht( '%s renamed %s from %s to %s.', $this->renderAuthor(), $this->renderObject(), $this->renderOldValue(), $this->renderNewValue()); } public function validateTransactions($object, array $xactions) { $errors = array(); if ($this->isEmptyTextTransaction($object->getTitle(), $xactions)) { $errors[] = $this->newRequiredError( pht('Tasks must have a title.')); } return $errors; } }