diff --git a/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php b/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php index ea09339d33..3b84520d86 100644 --- a/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php +++ b/src/applications/diffusion/conduit/ConduitAPI_diffusion_abstractquery_Method.php @@ -1,173 +1,174 @@ diffusionRequest = $request; return $this; } protected function getDiffusionRequest() { return $this->diffusionRequest; } /** * A wee bit of magic here. If @{method:shouldCreateDiffusionRequest} * returns false, this function grabs a repository object based on the * callsign directly. Otherwise, the repository was loaded when we created a * @{class:DiffusionRequest}, so this function just pulls it out of the * @{class:DiffusionRequest}. * * @return @{class:PhabricatorRepository} $repository */ protected function getRepository(ConduitAPIRequest $request) { if (!$this->repository) { if ($this->shouldCreateDiffusionRequest()) { $this->repository = $this->getDiffusionRequest()->getRepository(); } else { $callsign = $request->getValue('callsign'); - $repository = id(new PhabricatorRepository())->loadOneWhere( - 'callsign = %s', - $callsign); + $repository = id(new PhabricatorRepositoryQuery()) + ->setViewer($request->getUser()) + ->withCallsigns(array($callsign)) + ->executeOne(); if (!$repository) { throw new ConduitException('ERR-UNKNOWN-REPOSITORY'); } $this->repository = $repository; } } return $this->repository; } /** * You should probably not mess with this unless your conduit method is * involved with the creation / validation / etc. of * @{class:DiffusionRequest}s. If you are dealing with * @{class:DiffusionRequest}, setting this to false should help avoid * infinite loops. */ protected function setShouldCreateDiffusionRequest($should) { $this->shouldCreateDiffusionRequest = $should; return $this; } private function shouldCreateDiffusionRequest() { return $this->shouldCreateDiffusionRequest; } final public function defineErrorTypes() { return $this->defineCustomErrorTypes() + array( 'ERR-UNKNOWN-REPOSITORY' => pht('There is no repository with that callsign.'), 'ERR-UNKNOWN-VCS-TYPE' => pht('Unknown repository VCS type.'), 'ERR-UNSUPPORTED-VCS' => pht('VCS is not supported for this method.')); } /** * Subclasses should override this to specify custom error types. */ protected function defineCustomErrorTypes() { return array(); } final public function defineParamTypes() { return $this->defineCustomParamTypes() + array( 'callsign' => 'required string', 'branch' => 'optional string', ); } /** * Subclasses should override this to specify custom param types. */ protected function defineCustomParamTypes() { return array(); } /** * Subclasses should override these methods with the proper result for the * pertinent version control system, e.g. getGitResult for Git. * * If the result is not supported for that VCS, do not implement it. e.g. * Subversion (SVN) does not support branches. */ protected function getGitResult(ConduitAPIRequest $request) { throw new ConduitException('ERR-UNSUPPORTED-VCS'); } protected function getSVNResult(ConduitAPIRequest $request) { throw new ConduitException('ERR-UNSUPPORTED-VCS'); } protected function getMercurialResult(ConduitAPIRequest $request) { throw new ConduitException('ERR-UNSUPPORTED-VCS'); } /** * This method is final because most queries will need to construct a * @{class:DiffusionRequest} and use it. Consolidating this codepath and * enforcing @{method:getDiffusionRequest} works when we need it is good. * * @{method:getResult} should be overridden by subclasses as necessary, e.g. * there is a common operation across all version control systems that * should occur after @{method:getResult}, like formatting a timestamp. * * In the rare cases where one does not want to create a * @{class:DiffusionRequest} - suppose to avoid infinite loops in the * creation of a @{class:DiffusionRequest} - make sure to call * * $this->setShouldCreateDiffusionRequest(false); * * in the constructor of the pertinent Conduit method. */ final protected function execute(ConduitAPIRequest $request) { if ($this->shouldCreateDiffusionRequest()) { $drequest = DiffusionRequest::newFromDictionary( array( 'user' => $request->getUser(), 'callsign' => $request->getValue('callsign'), 'branch' => $request->getValue('branch'), 'path' => $request->getValue('path'), 'commit' => $request->getValue('commit'), )); $this->setDiffusionRequest($drequest); } return $this->getResult($request); } protected function getResult(ConduitAPIRequest $request) { $repository = $this->getRepository($request); $result = null; switch ($repository->getVersionControlSystem()) { case PhabricatorRepositoryType::REPOSITORY_TYPE_GIT: $result = $this->getGitResult($request); break; case PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL: $result = $this->getMercurialResult($request); break; case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN: $result = $this->getSVNResult($request); break; default: throw new ConduitException('ERR-UNKNOWN-VCS-TYPE'); break; } return $result; } } diff --git a/src/applications/diffusion/request/DiffusionRequest.php b/src/applications/diffusion/request/DiffusionRequest.php index 16e237e364..f3c17b952a 100644 --- a/src/applications/diffusion/request/DiffusionRequest.php +++ b/src/applications/diffusion/request/DiffusionRequest.php @@ -1,653 +1,663 @@ initializeFromDictionary($data); + return $object; } /** * Create a new request from an Aphront request dictionary. This is an * internal method that you generally should not call directly; instead, * call @{method:newFromDictionary}. * * @param map Map of Aphront request data. * @return DiffusionRequest New request object. * @task new */ final public static function newFromAphrontRequestDictionary( array $data, AphrontRequest $request) { $callsign = phutil_unescape_uri_path_component(idx($data, 'callsign')); - $object = self::newFromCallsign($callsign); + $object = self::newFromCallsign($callsign, $request->getUser()); $use_branches = $object->getSupportsBranches(); $parsed = self::parseRequestBlob(idx($data, 'dblob'), $use_branches); $object->setUser($request->getUser()); $object->initializeFromDictionary($parsed); $object->lint = $request->getStr('lint'); return $object; } /** * Internal. * * @task new */ final private function __construct() { // } /** * Internal. Use @{method:newFromDictionary}, not this method. * * @param string Repository callsign. + * @param PhabricatorUser Viewing user. * @return DiffusionRequest New request object. * @task new */ - final private static function newFromCallsign($callsign) { - $repository = id(new PhabricatorRepository())->loadOneWhere( - 'callsign = %s', - $callsign); - + final private static function newFromCallsign( + $callsign, + PhabricatorUser $viewer) { + + $repository = id(new PhabricatorRepositoryQuery()) + ->setViewer($viewer) + ->withCallsigns(array($callsign)) + ->executeOne(); if (!$repository) { throw new Exception("No such repository '{$callsign}'."); } return self::newFromRepository($repository); } /** * Internal. Use @{method:newFromDictionary}, not this method. * * @param PhabricatorRepository Repository object. * @return DiffusionRequest New request object. * @task new */ final private static function newFromRepository( PhabricatorRepository $repository) { $map = array( PhabricatorRepositoryType::REPOSITORY_TYPE_GIT => 'DiffusionGitRequest', PhabricatorRepositoryType::REPOSITORY_TYPE_SVN => 'DiffusionSvnRequest', PhabricatorRepositoryType::REPOSITORY_TYPE_MERCURIAL => 'DiffusionMercurialRequest', ); $class = idx($map, $repository->getVersionControlSystem()); if (!$class) { throw new Exception("Unknown version control system!"); } $object = new $class(); $object->repository = $repository; $object->callsign = $repository->getCallsign(); return $object; } /** * Internal. Use @{method:newFromDictionary}, not this method. * * @param map Map of parsed data. * @return void * @task new */ final private function initializeFromDictionary(array $data) { $this->path = idx($data, 'path'); $this->symbolicCommit = idx($data, 'commit'); $this->commit = idx($data, 'commit'); $this->line = idx($data, 'line'); $this->initFromConduit = idx($data, 'initFromConduit', true); if ($this->getSupportsBranches()) { $this->branch = idx($data, 'branch'); } if (!$this->getUser()) { $user = idx($data, 'user'); if (!$user) { throw new Exception( 'You must provide a PhabricatorUser in the dictionary!'); } $this->setUser($user); } $this->didInitialize(); } final protected function shouldInitFromConduit() { return $this->initFromConduit; } final public function setUser(PhabricatorUser $user) { $this->user = $user; return $this; } final public function getUser() { return $this->user; } public function getRepository() { return $this->repository; } public function getCallsign() { return $this->callsign; } public function setPath($path) { $this->path = $path; return $this; } public function getPath() { return $this->path; } public function getLine() { return $this->line; } public function getCommit() { return $this->commit; } public function getSymbolicCommit() { return $this->symbolicCommit; } public function getBranch() { return $this->branch; } public function getLint() { return $this->lint; } protected function getArcanistBranch() { return $this->getBranch(); } public function loadBranch() { return id(new PhabricatorRepositoryBranch())->loadOneWhere( 'repositoryID = %d AND name = %s', $this->getRepository()->getID(), $this->getArcanistBranch()); } public function getTagContent() { return $this->tagContent; } public function loadCommit() { if (empty($this->repositoryCommit)) { $repository = $this->getRepository(); $commit = id(new PhabricatorRepositoryCommit())->loadOneWhere( 'repositoryID = %d AND commitIdentifier = %s', $repository->getID(), $this->getCommit()); $this->repositoryCommit = $commit; } return $this->repositoryCommit; } public function loadArcanistProjects() { if (empty($this->arcanistProjects)) { $projects = id(new PhabricatorRepositoryArcanistProject())->loadAllWhere( 'repositoryID = %d', $this->getRepository()->getID()); $this->arcanistProjects = $projects; } return $this->arcanistProjects; } public function loadCommitData() { if (empty($this->repositoryCommitData)) { $commit = $this->loadCommit(); $data = id(new PhabricatorRepositoryCommitData())->loadOneWhere( 'commitID = %d', $commit->getID()); if (!$data) { $data = new PhabricatorRepositoryCommitData(); $data->setCommitMessage( '(This commit has not been fully parsed yet.)'); } $this->repositoryCommitData = $data; } return $this->repositoryCommitData; } /** * Retrieve a stable, permanent commit name. This returns a non-symbolic * identifier for the current commit: e.g., a specific commit hash in git * (NOT a symbolic name like "origin/master") or a specific revision number * in SVN (NOT a symbolic name like "HEAD"). * * @return string Stable commit name, like a git hash or SVN revision. Not * a symbolic commit reference. */ public function getStableCommitName() { if (!$this->stableCommitName) { $this->queryStableCommitName(); } return $this->stableCommitName; } final public function getRawCommit() { return $this->commit; } public function setCommit($commit) { $this->commit = $commit; return $this; } /* -( Managing Diffusion URIs )-------------------------------------------- */ /** * Generate a Diffusion URI using this request to provide defaults. See * @{method:generateDiffusionURI} for details. This method is the same, but * preserves the request parameters if they are not overridden. * * @param map See @{method:generateDiffusionURI}. * @return PhutilURI Generated URI. * @task uri */ public function generateURI(array $params) { if (empty($params['stable'])) { $default_commit = $this->getRawCommit(); } else { $default_commit = $this->getStableCommitName(); } $defaults = array( 'callsign' => $this->getCallsign(), 'path' => $this->getPath(), 'branch' => $this->getBranch(), 'commit' => $default_commit, 'lint' => idx($params, 'lint', $this->getLint()), ); foreach ($defaults as $key => $val) { if (!isset($params[$key])) { // Overwrite NULL. $params[$key] = $val; } } return self::generateDiffusionURI($params); } /** * Generate a Diffusion URI from a parameter map. Applies the correct encoding * and formatting to the URI. Parameters are: * * - `action` One of `history`, `browse`, `change`, `lastmodified`, * `branch` or `revision-ref`. The action specified by the URI. * - `callsign` Repository callsign. * - `branch` Optional if action is not `branch`, branch name. * - `path` Optional, path to file. * - `commit` Optional, commit identifier. * - `line` Optional, line range. * - `lint` Optional, lint code. * - `params` Optional, query parameters. * * The function generates the specified URI and returns it. * * @param map See documentation. * @return PhutilURI Generated URI. * @task uri */ public static function generateDiffusionURI(array $params) { $action = idx($params, 'action'); $callsign = idx($params, 'callsign'); $path = idx($params, 'path'); $branch = idx($params, 'branch'); $commit = idx($params, 'commit'); $line = idx($params, 'line'); if (strlen($callsign)) { $callsign = phutil_escape_uri_path_component($callsign).'/'; } if (strlen($branch)) { $branch = phutil_escape_uri_path_component($branch).'/'; } if (strlen($path)) { $path = ltrim($path, '/'); $path = str_replace(array(';', '$'), array(';;', '$$'), $path); $path = phutil_escape_uri($path); } $path = "{$branch}{$path}"; if (strlen($commit)) { $commit = str_replace('$', '$$', $commit); $commit = ';'.phutil_escape_uri($commit); } if (strlen($line)) { $line = '$'.phutil_escape_uri($line); } $req_callsign = false; $req_branch = false; $req_commit = false; switch ($action) { case 'history': case 'browse': case 'change': case 'lastmodified': case 'tags': case 'branches': case 'lint': $req_callsign = true; break; case 'branch': $req_callsign = true; $req_branch = true; break; case 'commit': $req_callsign = true; $req_commit = true; break; } if ($req_callsign && !strlen($callsign)) { throw new Exception( "Diffusion URI action '{$action}' requires callsign!"); } if ($req_branch && !strlen($branch)) { throw new Exception( "Diffusion URI action '{$action}' requires branch!"); } if ($req_commit && !strlen($commit)) { throw new Exception( "Diffusion URI action '{$action}' requires commit!"); } switch ($action) { case 'change': case 'history': case 'browse': case 'lastmodified': case 'tags': case 'branches': case 'lint': $uri = "/diffusion/{$callsign}{$action}/{$path}{$commit}{$line}"; break; case 'branch': $uri = "/diffusion/{$callsign}repository/{$path}"; break; case 'external': $commit = ltrim($commit, ';'); $uri = "/diffusion/external/{$commit}/"; break; case 'rendering-ref': // This isn't a real URI per se, it's passed as a query parameter to // the ajax changeset stuff but then we parse it back out as though // it came from a URI. $uri = rawurldecode("{$path}{$commit}"); break; case 'commit': $commit = ltrim($commit, ';'); $callsign = rtrim($callsign, '/'); $uri = "/r{$callsign}{$commit}"; break; default: throw new Exception("Unknown Diffusion URI action '{$action}'!"); } if ($action == 'rendering-ref') { return $uri; } $uri = new PhutilURI($uri); if (isset($params['lint'])) { $params['params'] = idx($params, 'params', array()) + array( 'lint' => $params['lint'], ); } if (idx($params, 'params')) { $uri->setQueryParams($params['params']); } return $uri; } /** * Internal. Public only for unit tests. * * Parse the request URI into components. * * @param string URI blob. * @param bool True if this VCS supports branches. * @return map Parsed URI. * * @task uri */ public static function parseRequestBlob($blob, $supports_branches) { $result = array( 'branch' => null, 'path' => null, 'commit' => null, 'line' => null, ); $matches = null; if ($supports_branches) { // Consume the front part of the URI, up to the first "/". This is the // path-component encoded branch name. if (preg_match('@^([^/]+)/@', $blob, $matches)) { $result['branch'] = phutil_unescape_uri_path_component($matches[1]); $blob = substr($blob, strlen($matches[1]) + 1); } } // Consume the back part of the URI, up to the first "$". Use a negative // lookbehind to prevent matching '$$'. We double the '$' symbol when // encoding so that files with names like "money/$100" will survive. $pattern = '@(?:(?:^|[^$])(?:[$][$])*)[$]([\d-,]+)$@'; if (preg_match($pattern, $blob, $matches)) { $result['line'] = $matches[1]; $blob = substr($blob, 0, -(strlen($matches[1]) + 1)); } // We've consumed the line number if it exists, so unescape "$" in the // rest of the string. $blob = str_replace('$$', '$', $blob); // Consume the commit name, stopping on ';;'. We allow any character to // appear in commits names, as they can sometimes be symbolic names (like // tag names or refs). if (preg_match('@(?:(?:^|[^;])(?:;;)*);([^;].*)$@', $blob, $matches)) { $result['commit'] = $matches[1]; $blob = substr($blob, 0, -(strlen($matches[1]) + 1)); } // We've consumed the commit if it exists, so unescape ";" in the rest // of the string. $blob = str_replace(';;', ';', $blob); if (strlen($blob)) { $result['path'] = $blob; } $parts = explode('/', $result['path']); foreach ($parts as $part) { // Prevent any hyjinx since we're ultimately shipping this to the // filesystem under a lot of workflows. if ($part == '..') { throw new Exception("Invalid path URI."); } } return $result; } /** * Check that the working copy of the repository is present and readable. * * @param string Path to the working copy. */ protected function validateWorkingCopy($path) { if (!is_readable(dirname($path))) { $this->raisePermissionException(); } if (!Filesystem::pathExists($path)) { $this->raiseCloneException(); } } protected function raisePermissionException() { $host = php_uname('n'); $callsign = $this->getRepository()->getCallsign(); throw new DiffusionSetupException( "The clone of this repository ('{$callsign}') on the local machine " . "('{$host}') could not be read. Ensure that the repository is in a " . "location where the web server has read permissions."); } protected function raiseCloneException() { $host = php_uname('n'); $callsign = $this->getRepository()->getCallsign(); throw new DiffusionSetupException( "The working copy for this repository ('{$callsign}') hasn't been ". "cloned yet on this machine ('{$host}'). Make sure you've started the ". "Phabricator daemons. If this problem persists for longer than a clone ". "should take, check the daemon logs (in the Daemon Console) to see if ". "there were errors cloning the repository. Consult the 'Diffusion User ". "Guide' in the documentation for help setting up repositories."); } final protected function expandCommitName() { if ($this->shouldInitFromConduit()) { $commit_data = DiffusionQuery::callConduitWithDiffusionRequest( $this->getUser(), $this, 'diffusion.expandshortcommitquery', array( 'commit' => $this->commit )); } else { $repository = $this->getRepository(); $this->validateWorkingCopy($repository->getLocalPath()); $query = DiffusionExpandShortNameQuery::newFromRepository( $repository); $query->setCommit($this->commit); $commit_data = $query->expand(); } $this->commit = $commit_data['commit']; $this->commitType = $commit_data['commitType']; $this->tagContent = $commit_data['tagContent']; } private function queryStableCommitName() { if ($this->commit) { $this->stableCommitName = $this->commit; } else if ($this->shouldInitFromConduit()) { $this->stableCommitName = DiffusionQuery::callConduitWithDiffusionRequest( $this->getUser(), $this, 'diffusion.stablecommitnamequery', array( 'branch' => $this->getBranch() )); } else { $query = DiffusionStableCommitNameQuery::newFromRepository( $this->getRepository()); $query->setBranch($this->getBranch()); $this->stableCommitName = $query->load(); } return $this->stableCommitName; } }